Replace calls to dbg! with log::debug! + env_logger
#89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can use the RUST_LOG environment variable to control the log level.
KonaeAkira
requested changes
Nov 18, 2024
There was a problem hiding this comment.
Nice! However, I would leave the debug prints in the tests as they are now for the following reasons:
- Test output is not seen by the end user
- When running tests using
cargo test, thestderroutput is only displayed in case the test fails. - The stuff that is currently printed is crucial for debugging failing test cases, so they should always be visible when a test fails.
Roger. |
KonaeAkira
changed the title
dbg! with log::debug! + env_logger
|
Closed, because debug output is a must-have for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use the
RUST_LOGenvironment variable to control the log level. According to thedbgdocumentation:I used
log::error!in a few places where it seemed appropriate. Some of thedbg!calls probably make more sense astrace!orinfo!, but those can be changed later.